Debezium SQL Server Connector native support #1193 #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
May 29, 2020
JiriOndrusek
force-pushed
the
193_debezium_sqlserver
branch
4 times, most recently
from
07c0dbb
to
f9608c5
Compare
| SQL server may require encryption. In that case `quarkus.ssl.native=false` parameter has to be added during execution. | ||
| See https://quarkus.io/guides/native-and-ssl for more details. | ||
|
|
||
| === Integration testing |
There was a problem hiding this comment.
Maybe move this section into a dedicated README in the debezium itest module. It's not really required information for the most users.
integration-tests/debezium/pom.xml
Outdated
| @@ -39,8 +40,11 @@ | |||
| <!-- mvn process-resources -Pformat from the root directory --> | |||
| <mvnd.builder.rule>camel-quarkus-debezium-postgres-deployment,camel-quarkus-debezium-mysql-deployment,camel-quarkus-support-policy-deployment</mvnd.builder.rule> | |||
There was a problem hiding this comment.
camel-quarkus-debezium-sqlserver-deployment seems to be missing.
There was a problem hiding this comment.
@jamesnetherton Both changes are added to the PR.
JiriOndrusek
force-pushed
the
193_debezium_sqlserver
branch
from
f9608c5
to
c96a439
Compare
|
@JiriOndrusek please can you rebase and resolve conflicts. |
JiriOndrusek
force-pushed
the
193_debezium_sqlserver
branch
from
c96a439
to
d97f17c
Compare
|
@jamesnetherton rebased and conflicts resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:#1193
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html