Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the local Antora build produce .htaccess file with redirects based #1342

Merged
merged 1 commit into from Jun 25, 2020

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Jun 11, 2020

on :page-aliases: attributes in the AsciiDoc pages the content of that
file can by copied to
https://github.com/apache/camel-website/blob/master/static/.htaccess

Comment on lines 7 to 25
"@antora/cli": "~2.3.0",
"@antora/site-generator-default": "~2.3.0",
"@antora/asciidoc-loader": "2.3.0",
"@antora/cli": "2.3.0",
"@antora/content-aggregator": "2.3.0",
"@antora/content-classifier": "2.3.0",
"@antora/document-converter": "2.3.0",
"@antora/playbook-builder": "2.3.0",
"@antora/site-generator-default": "2.3.0",
"@antora/xref-validator": "gitlab:antora/xref-validator",
"lite-server": "^2.4.0"
"@djencks/asciidoctor-antora-indexer": "^0.0.2",
"escape-string-regexp": "~2.0",
"gulp": "~4.0",
"gulp-cheerio": "^1.0.0",
"gulp-htmlmin": "~5.0",
"html-validate": "~1.2",
"hugo-cli": "~0.11",
"link-checker": "~1.2",
"npm-run-all": "~4.1",
"opal-runtime": "1.0.11",
"toml": "~3.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djencks here is what I did to overcome the urls.redirect_facility: must be one of the possible values: ["disabled","netlify","nginx","static"]: value was "httpd" error trying to follow your advice to get "configuration for the checks that assures that the xref-checker is using a 2.3+ Antora":

I copied all devDependencies from camel and ran yarn install && yarn upgrade.

As a result yarn checks pass now.

That could mean mission completed, but I suspect copying all devDependencies from camel is a bit too brute force, but I confess I have no clue which ones could be left out. Is it OK to leave it as is or you perhaps want to propose some changes?

@djencks
Copy link
Contributor

djencks commented Jun 20, 2020 via email

on :page-aliases: attributes in the AsciiDoc pages the content of that
file can by copied to
https://github.com/apache/camel-website/blob/master/static/.htaccess
@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 25, 2020

@djencks many thanks, the deps proposed by you seem to work.

@ppalaga ppalaga merged commit 4aab307 into apache:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants