New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the local Antora build produce .htaccess file with redirects based #1342
Conversation
docs/package.json
Outdated
"@antora/cli": "~2.3.0", | ||
"@antora/site-generator-default": "~2.3.0", | ||
"@antora/asciidoc-loader": "2.3.0", | ||
"@antora/cli": "2.3.0", | ||
"@antora/content-aggregator": "2.3.0", | ||
"@antora/content-classifier": "2.3.0", | ||
"@antora/document-converter": "2.3.0", | ||
"@antora/playbook-builder": "2.3.0", | ||
"@antora/site-generator-default": "2.3.0", | ||
"@antora/xref-validator": "gitlab:antora/xref-validator", | ||
"lite-server": "^2.4.0" | ||
"@djencks/asciidoctor-antora-indexer": "^0.0.2", | ||
"escape-string-regexp": "~2.0", | ||
"gulp": "~4.0", | ||
"gulp-cheerio": "^1.0.0", | ||
"gulp-htmlmin": "~5.0", | ||
"html-validate": "~1.2", | ||
"hugo-cli": "~0.11", | ||
"link-checker": "~1.2", | ||
"npm-run-all": "~4.1", | ||
"opal-runtime": "1.0.11", | ||
"toml": "~3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djencks here is what I did to overcome the urls.redirect_facility: must be one of the possible values: ["disabled","netlify","nginx","static"]: value was "httpd"
error trying to follow your advice to get "configuration for the checks that assures that the xref-checker is using a 2.3+ Antora":
I copied all devDependencies from camel and ran yarn install && yarn upgrade
.
As a result yarn checks
pass now.
That could mean mission completed, but I suspect copying all devDependencies from camel is a bit too brute force, but I confess I have no clue which ones could be left out. Is it OK to leave it as is or you perhaps want to propose some changes?
I think this is enough:
"devDependencies": {
"@antora/asciidoc-loader": "2.3.3",
"@antora/cli": "2.3.3",
"@antora/content-aggregator": "2.3.3",
"@antora/content-classifier": "2.3.3",
"@antora/document-converter": "2.3.3",
"@antora/playbook-builder": "2.3.3",
"@antora/site-generator-default": "2.3.3",
"@antora/xref-validator": "gitlab:antora/xref-validator",
"lite-server": "^2.4.0"
},
Does this work for you?
It works for me with v. 2.3.0, but why not upgrade?
Thanks!
David Jencks
… On Jun 19, 2020, at 12:17 AM, Peter Palaga ***@***.***> wrote:
@ppalaga commented on this pull request.
In docs/package.json <#1342 (comment)>:
> - ***@***.***/cli": "~2.3.0",
- ***@***.***/site-generator-default": "~2.3.0",
+ ***@***.***/asciidoc-loader": "2.3.0",
+ ***@***.***/cli": "2.3.0",
+ ***@***.***/content-aggregator": "2.3.0",
+ ***@***.***/content-classifier": "2.3.0",
+ ***@***.***/document-converter": "2.3.0",
+ ***@***.***/playbook-builder": "2.3.0",
+ ***@***.***/site-generator-default": "2.3.0",
***@***.***/xref-validator": "gitlab:antora/xref-validator",
- "lite-server": "^2.4.0"
+ ***@***.***/asciidoctor-antora-indexer": "^0.0.2",
+ "escape-string-regexp": "~2.0",
+ "gulp": "~4.0",
+ "gulp-cheerio": "^1.0.0",
+ "gulp-htmlmin": "~5.0",
+ "html-validate": "~1.2",
+ "hugo-cli": "~0.11",
+ "link-checker": "~1.2",
+ "npm-run-all": "~4.1",
+ "opal-runtime": "1.0.11",
+ "toml": "~3.0"
@djencks <https://github.com/djencks> here is what I did to overcome the urls.redirect_facility: must be one of the possible values: ["disabled","netlify","nginx","static"]: value was "httpd" error trying to follow your advice to get "configuration for the checks that assures that the xref-checker is using a 2.3+ Antora":
I copied all devDependencies from camel and ran yarn install && yarn upgrade.
As a result yarn checks pass now.
That could mean mission completed, but I suspect copying all devDependencies from camel is a bit too brute force, but I confess I have no clue which ones could be left out. Is it OK to leave it as is or you perhaps want to propose some changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1342 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXTDHZTKZWN35Q6PYGTRXMGJ3ANCNFSM4N3RDHZA>.
|
on :page-aliases: attributes in the AsciiDoc pages the content of that file can by copied to https://github.com/apache/camel-website/blob/master/static/.htaccess
@djencks many thanks, the deps proposed by you seem to work. |
on :page-aliases: attributes in the AsciiDoc pages the content of that
file can by copied to
https://github.com/apache/camel-website/blob/master/static/.htaccess