Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add test to validate camel registry hooks in ArC #146

Merged
merged 1 commit into from Aug 19, 2019

Conversation

lburgazzoli
Copy link
Contributor

No description provided.

@asf-ci
Copy link

asf-ci commented Aug 19, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/103/

@lburgazzoli lburgazzoli merged commit 9470371 into apache:master Aug 19, 2019
@lburgazzoli lburgazzoli deleted the test-arc-lookup branch August 19, 2019 20:20
Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests, @lburgazzoli !

I wonder how important would it be to test the bean scenarios with deferInitPhase true and false? (I actually think deferInitPhase true is more common and should be made the default while we are not able to autodetect).

</dependency>



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this too many empty lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants