Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Camel AS2 Modules as Quarkus Extension #1471 #1549

Merged

Conversation

JiriOndrusek
Copy link
Contributor

Closes #1471

As a part of the solution extension-support/bouncycastle was created. Bouncy castle security provider is required for camel-as2 and without proper initialization there are no digests working with quarkus in native.

Replaces #1488

[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html

@JiriOndrusek JiriOndrusek force-pushed the 1471-as2-native-extensions branch 3 times, most recently from fd807b8 to 34f5fdb Compare August 21, 2020 07:20
@JiriOndrusek
Copy link
Contributor Author

Should pass the CI. But it fails with:
Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (antora-xref-check) on project camel-quarkus-docs: Command execution failed.: Process exited with an error: 1 (Exit value: 1)

@jamesnetherton , @ppalaga do you know, what could be wrong? (Local build is working correctly and generated docs seems to be correct)

@ppalaga
Copy link
Contributor

ppalaga commented Aug 21, 2020

I think the failure is caused by the fact that you have some stale files in docs that were produced by the old version of the tooling (that we upgraded recently) and the new version of the tooling does not like them. So please try the following:

  • Remove all files your PR has added to docs module
  • Rebuild the whole tree mvn clean install -DskipTests -Denforcer.skip -Dquarkus.build.skip

@ppalaga
Copy link
Contributor

ppalaga commented Aug 21, 2020

  • Remove all files your PR has added to docs module

Esp. this one docs/modules/ROOT/pages/extensions/as2.adoc

@JiriOndrusek
Copy link
Contributor Author

JiriOndrusek commented Aug 21, 2020

Thanks @ppalaga. I've removed this file some time ago, but probably I've introduced it back during rebase. Current build is executed without this doc file.
IMHO it would be nice if this error could happen also locally - I'm not sure why it didn't fail during local build

@JiriOndrusek
Copy link
Contributor Author

Good to merge from my point of view

@ppalaga ppalaga merged commit a86ee84 into apache:camel-master Aug 21, 2020
@ppalaga
Copy link
Contributor

ppalaga commented Aug 21, 2020

Thanks, @JiriOndrusek !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants