Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add velocity extension #837 #1634

Closed
wants to merge 4 commits into from

Conversation

dc2tom
Copy link

@dc2tom dc2tom commented Aug 26, 2020

Adding so @ppalaga can review if any of this is useful for him

@dc2tom dc2tom mentioned this pull request Aug 26, 2020
@ppalaga
Copy link
Contributor

ppalaga commented Aug 26, 2020

Perfect, thanks for sharing! I can take it over, if you do not have time to finish it?

@dc2tom
Copy link
Author

dc2tom commented Aug 26, 2020

Perfect, thanks for sharing! I can take it over, if you do not have time to finish it?

Feel free :) Glad I could at least help out a little

@ppalaga ppalaga marked this pull request as draft August 26, 2020 15:18
@JiriOndrusek
Copy link
Contributor

I've created a new PR with velocity native extension - #1804
@dc2tom you can look into my PR and close this one, if you agree with it.

@dc2tom
Copy link
Author

dc2tom commented Sep 18, 2020

Thanks - as commented on your own PR I'd just suggest you port a few more tests over to cover more use cases . happy to close this one.

@dc2tom dc2tom closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants