Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote AWS 2 Lambda to native #1730

Merged
merged 1 commit into from Sep 8, 2020
Merged

Promote AWS 2 Lambda to native #1730

merged 1 commit into from Sep 8, 2020

Conversation

Jeansen
Copy link
Contributor

@Jeansen Jeansen commented Sep 8, 2020

No description provided.

oscerd
oscerd requested changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this javascript should be in the extension.

@Jeansen
Copy link
Contributor Author

Jeansen commented Sep 8, 2020

I don't think this javascript should be in the extension.

so, remove the whole lib folder with the .js files?

@Jeansen
Copy link
Contributor Author

Jeansen commented Sep 8, 2020

I see, the other extensions do not have it either, will remove the lib folder

ppalaga
ppalaga approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jeansen ! A minor comment inline. Besides, if you could please use more descriptive commit messages next time. Issue title would be nice in addition to the issue number.

integration-tests/dropbox/pom.xml Outdated Show resolved Hide resolved
@Jeansen
Copy link
Contributor Author

Jeansen commented Sep 8, 2020

Thanks @Jeansen ! A minor comment inline. Besides, if you could please use more descriptive commit messages next time. Issue title would be nice in addition to the issue number.

@ppalaga I am sorry, I've added the issue title to my commit.

@ppalaga
Copy link
Contributor

ppalaga commented Sep 8, 2020

It is perfect from my PoV now, thanks @Jeansen !

oscerd
oscerd approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@ppalaga ppalaga merged commit e8fb61a into apache:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppalaga ppalaga ppalaga approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jeansen @ppalaga @oscerd