Enable Spring dependent extensions to work with Quarkus Spring #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Oct 21, 2020
ppalaga
approved these changes
Oct 21, 2020
jamesnetherton
force-pushed
the
spring-fixes
branch
from
e002c16
to
aedb418
Compare
Latest commit adds a README to the spring support extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around the issue I identified in #1759.
I did some analysis of Spring code paths that get executed in the Camel unit tests and came up with a list of package includes & excludes for shading.
The itests pass ok, but I can't check for every possible code path. Is it better / safer to shade all packages, instead of selectively including them? Obviously there's a chance that some required stuff may have been left out.