Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Redis Aggregation Repository support in JVM mode only #2085 #2106

Merged
merged 1 commit into from Jan 7, 2021

Conversation

aldettinger
Copy link
Contributor

[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html

JVM only as Redisson seems not quarkus native friendly, I'm opening a follow up.

@aldettinger
Copy link
Contributor Author

I'm not able to workaround the build issue. But it seems unrelated.

@ppalaga
Copy link
Contributor

ppalaga commented Jan 7, 2021

I'm not able to workaround the build issue. But it seems unrelated.

See #2110

@jamesnetherton
Copy link
Contributor

Wondering for native support whether we should think about having Camel support for vertx-redis-client? Then we could leverage Quarkus Redis and get the native bits for free, rather than spend time on Redisson.

@aldettinger
Copy link
Contributor Author

Yeah, the quarkus community has taken this path. The potential benefits make it worth taking a look.

As far as I see, changing the underlying client shouldn't break any contract, so I think it is safe to start with redisson JVM only and then upgrade to vertx-redis-client for native.

@aldettinger aldettinger merged commit 4c4493b into apache:master Jan 7, 2021
@aldettinger aldettinger deleted the CAMEL-QUARKUS-2085 branch January 7, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants