New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgarde to quarkus v0.23.1 #211
Conversation
Thx @oscerd for the initial work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor issues inline.
integration-tests/mail/pom.xml
Outdated
@@ -26,7 +26,7 @@ | |||
<modelVersion>4.0.0</modelVersion> | |||
|
|||
<artifactId>camel-quarkus-integration-test-mail</artifactId> | |||
<name>Camel Quarkus :: Integration Tests Mail :: Test</name> | |||
<name>Camel Quarkus :: Integration Tests :: Mail :: Test</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<name>Camel Quarkus :: Integration Tests :: Mail</name>
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
<dependency> | ||
<groupId>org.jvnet.mock-javamail</groupId> | ||
<artifactId>mock-javamail</artifactId> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is managed in integration-tests/pom.xml and should be removed from there too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<mock-javamail-version>1.9</mock-javamail-version>
can be removed from integration-tests/pom.xml
mock-javamail-version
should perhaps be renamed to mock-javamail.version
in the build parent.
f61e020
to
9fe12f9
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've runned itests ok just in case.
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Fixes #209