Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgarde to quarkus v0.23.1 #211

Merged
merged 4 commits into from Sep 30, 2019
Merged

Conversation

lburgazzoli
Copy link
Contributor

Fixes #209

@lburgazzoli
Copy link
Contributor Author

Thx @oscerd for the initial work

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor issues inline.

@@ -26,7 +26,7 @@
<modelVersion>4.0.0</modelVersion>

<artifactId>camel-quarkus-integration-test-mail</artifactId>
<name>Camel Quarkus :: Integration Tests Mail :: Test</name>
<name>Camel Quarkus :: Integration Tests :: Mail :: Test</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<name>Camel Quarkus :: Integration Tests :: Mail</name> maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<dependency>
<groupId>org.jvnet.mock-javamail</groupId>
<artifactId>mock-javamail</artifactId>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is managed in integration-tests/pom.xml and should be removed from there too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<mock-javamail-version>1.9</mock-javamail-version> can be removed from integration-tests/pom.xml

mock-javamail-version should perhaps be renamed to mock-javamail.version in the build parent.

@lburgazzoli
Copy link
Contributor Author

done

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've runned itests ok just in case.

@asf-ci
Copy link

asf-ci commented Sep 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/175/

@oscerd oscerd merged commit 7719640 into apache:master Sep 30, 2019
@lburgazzoli lburgazzoli deleted the quarkus-0.23.1 branch September 30, 2019 10:06
@asf-ci
Copy link

asf-ci commented Sep 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/176/

@asf-ci
Copy link

asf-ci commented Sep 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/177/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Quarkus 0.23.0
5 participants