Remove docker.io prefix for images #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppalaga
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
wdyt @ppalaga @jamesnetherton should i raise issue on testcontainers/docker-java as well ?
I don't think it is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With docker.io prefix the auth from
docker loginis not working in testcontainers because this line (https://github.com/docker-java/docker-java/blob/master/docker-java-core/src/main/java/com/github/dockerjava/core/DockerConfigFile.java#L51) compare withhttps://index.docker.io/v1/which fails and no auth is used. And from documentation (https://www.testcontainers.org/quickstart/junit_5_quickstart#2-get-testcontainers-to-run-a-redis-container-during-our-tests) i can see there is no docker.io prefix used either.wdyt @ppalaga @jamesnetherton should i raise issue on testcontainers/docker-java as well ?