Syslog native support #2197
Merged
Syslog native support #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Feb 3, 2021
jamesnetherton
force-pushed
the
syslog
branch
from
0ccde40
to
a452482
Compare
aldettinger
reviewed
Feb 3, 2021
...-tests/syslog/src/main/java/org/apache/camel/quarkus/component/syslog/it/SyslogResource.java
Outdated
Show resolved
Hide resolved
jamesnetherton
force-pushed
the
syslog
branch
from
a452482
to
1dc34b7
Compare
aldettinger
reviewed
Feb 3, 2021
...-tests/syslog/src/main/java/org/apache/camel/quarkus/component/syslog/it/SyslogResource.java
Outdated
Show resolved
Hide resolved
aldettinger
approved these changes
Feb 3, 2021
jamesnetherton
force-pushed
the
syslog
branch
from
1dc34b7
to
012c795
Compare
|
Merging despite unrelated build failures. Syslog tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #595
I had to register a couple of classes for reflection to make this work. I didn't bother raising issues to fix since the issue with
NettyConfigurationis fixed in CAMEL-16129, so I can remove that on thecamel-masterbranch. And I opened quarkusio/quarkus#14786 to getNioDatagramChanneladded on the Quarkus side, hence I can hopefully clean it up on thequarkus-masterbranch once merged.