Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test AWS 2 DynamoDB properly #2238

Merged
merged 3 commits into from Feb 12, 2021
Merged

Test AWS 2 DynamoDB properly #2238

merged 3 commits into from Feb 12, 2021

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Feb 11, 2021

aldettinger
aldettinger approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of nitpicking :) LGTM. Nice to see the AWS2 test coverage growing 👍

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 11, 2021

058d403: removed the out-of-date sqs comments, fixed the generation of the grouped module

@ppalaga
Copy link
Contributor Author

ppalaga commented Feb 12, 2021

ignoring the spring-rabbitmq failure.

@ppalaga ppalaga merged commit 81b7c64 into apache:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@aldettinger aldettinger aldettinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ppalaga @oscerd @aldettinger