Add support for quarkus provided event loop #231
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -30,4 +34,26 @@ public Object unwrap(Object value) { | |||
| ? ((RuntimeValue)value).getValue() | |||
| : value; | |||
| } | |||
|
|
|||
| // TODO: fix upstream | |||
There was a problem hiding this comment.
Whats the issue upstream?
There was a problem hiding this comment.
Sorry was late and forgot to open an issue. The problem is that the default implementations does not merge the results from the repositories with the fallback one so if you bind something to the registry and one of the repositories return a non null set, then you' won't get the local instance but an empty answer.
...s/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
Outdated
Show resolved
Hide resolved
lburgazzoli
force-pushed
the
github-131
branch
from
161373f
to
b1a6bcb
Compare
|
Okay fixing the registry upstream |
|
Refer to this link for build results (access rights to CI server needed): |
| // instantiate them in this phase. | ||
| // | ||
| boolean blacklisted = si.path.endsWith("reactive-executor") || si.path.endsWith("platform-http"); | ||
| if (blacklisted) { |
There was a problem hiding this comment.
No problem to accept this for now but it does not look like a sustainable long term solution. We should find a way for the extensions/components to blacklist themselves (via BuildItem, or however else). WDYT?
| import org.apache.camel.spi.ReactiveExecutor; | ||
|
|
||
| /** | ||
| * Holds the {@link CamelMain} {@link RuntimeValue}. |
There was a problem hiding this comment.
s/CamelMain/ReactiveExecutor/
| @@ -117,18 +117,21 @@ public static boolean isPublic(ClassInfo ci) { | |||
| * services from resources belonging to META-INF/services/org/apache/camel. | |||
| */ | |||
| public static class ServiceInfo { | |||
| public final Path path; | |||
There was a problem hiding this comment.
A piece of JavaDoc stating what Path is this would be nice. Something like The path from which this {@link ServiceInfo} was read. E.g {@code META-INF/services/org/apache/camel/my-service}
| import org.apache.camel.quarkus.core.deployment.CamelReactiveExecutorBuildItem; | ||
| import org.apache.camel.quarkus.reactive.executor.ReactiveExecutorRecorder; | ||
|
|
||
| public class BuildProcessor { |
There was a problem hiding this comment.
I must say I find using the same names like BuildProcessor in different extensions rather impractical. Having two BuildProcessor s open in an IDE makes it hard to figure out which editor tab belongs to which class.
Fixes #131