Add tests for MicroProfile metrics configuration options #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
May 18, 2021
zbendhiba
reviewed
May 18, 2021
| @RegisterExtension | ||
| static final QuarkusUnitTest CONFIG = new QuarkusUnitTest() | ||
| .setArchiveProducer(() -> ShrinkWrap.create(JavaArchive.class) | ||
| .addAsResource(applicationProperties(), "application.properties")); |
There was a problem hiding this comment.
Just as a curiosity, does this change the application.properties for tests ?
There was a problem hiding this comment.
Yes, it's a way of providing a set of configuration properties without having the physical file on the classpath. ShrinkWrap lets you build an application JAR with the relevant classes and resources.
There was a problem hiding this comment.
Thanks! I learnt something new !!
zbendhiba
approved these changes
May 18, 2021
aldettinger
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.