Fix aws2-support dependency on httpclient #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
May 27, 2021
ppalaga
approved these changes
May 27, 2021
There was a problem hiding this comment.
What a shame on me, @aloubyansky ! Sorry for the false alarm and thanks a lot for figuring out how to fix this!
|
That actually made me realize our extension dependency validation has a bug. It obviously missed this case. I am going to fix it. |
|
Sorry, I have hit the wrong button |
|
Merged after testing locally. Thanks again, @aloubyansky ! |
|
The enhancement to the extension dependency validation to catch this sort of misconfig quarkusio/quarkus#17498 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2670