Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dev services for Kafka itests #2734

Merged
merged 1 commit into from Jun 7, 2021

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesnetherton could you please explain how the dev services impact our Integration tests?

@jamesnetherton
Copy link
Contributor Author

@jamesnetherton could you please explain how the dev services impact our Integration tests?

From what I saw it only does basic configuration of the Kafka container. E.g no SASL / SSL etc.

We may want to do a follow up and look into improving things. We currently have 3 competing ways of doing containerised tests:

  1. Plain old testcontainers
  2. Camel test infra
  3. Quarkus dev support

We should try to follow one approach if possible.

@ppalaga
Copy link
Contributor

ppalaga commented Jun 7, 2021

@jamesnetherton could you please explain how the dev services impact our Integration tests?

From what I saw it only does basic configuration of the Kafka container. E.g no SASL / SSL etc.

I thought they were only for dev mode. Now I see they are also for test mode. Good to know. Thanks for explaining.

We may want to do a follow up and look into improving things. We currently have 3 competing ways of doing containerised tests:

  1. Plain old testcontainers
  2. Camel test infra

Are we using it somewhere in Camel Quarkus already?

  1. Quarkus dev support

We should try to follow one approach if possible.

+1

@ppalaga ppalaga merged commit 32de570 into apache:main Jun 7, 2021
@jamesnetherton jamesnetherton deleted the fix-kafka-ssl-itests branch June 7, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants