camel-jackson-avro data format native support #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jun 9, 2021
jamesnetherton
force-pushed
the
jackson-avro-native
branch
from
e0ced08
to
d6a8ecf
Compare
aldettinger
approved these changes
Jun 9, 2021
ppalaga
reviewed
Jun 9, 2021
Comment on lines
131
to
134
| InputStream resource = JacksonAvroResource.class.getResourceAsStream(schemaPath); | ||
| Schema raw = new Schema.Parser().setValidate(true).parse(resource); | ||
| AvroSchema schema = new AvroSchema(raw); | ||
| return ex -> schema; |
There was a problem hiding this comment.
Suggested change
| InputStream resource = JacksonAvroResource.class.getResourceAsStream(schemaPath); | |
| Schema raw = new Schema.Parser().setValidate(true).parse(resource); | |
| AvroSchema schema = new AvroSchema(raw); | |
| return ex -> schema; | |
| try (InputStream resource = JacksonAvroResource.class.getResourceAsStream(schemaPath)) { | |
| Schema raw = new Schema.Parser().setValidate(true).parse(resource); | |
| AvroSchema schema = new AvroSchema(raw); | |
| return ex -> schema; | |
| } |
ppalaga
approved these changes
Jun 9, 2021
jamesnetherton
force-pushed
the
jackson-avro-native
branch
from
d6a8ecf
to
798a5be
Compare
Thanks - applied also to the jackson-protobuf test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.