Avoid duplicating code in BaseModel & FastCamelContext #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jun 11, 2021
lburgazzoli
approved these changes
Jun 11, 2021
jamesnetherton
force-pushed
the
fix-dupe-model-context
branch
from
81254be
to
6aefbc1
Compare
|
@jamesnetherton thanks for this PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stripped out most of the content from
FastCamelContextexcept for CQ specific things.I wasn't sure about methods like
getComponentParameterJsonSchemaso I left them as-is. Our impl is mostly the same as the one inDefaultCamelContext, except that it does a registry lookup, which I'm assuming is some kind of optimisation?