Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid port clashes where it may already be reserved via the build-helper-maven-plugin #2769

Merged
merged 1 commit into from Jun 11, 2021

Conversation

jamesnetherton
Copy link
Contributor

Relates to findings in #2671.

Copy link
Contributor

@zbendhiba zbendhiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !!

@jamesnetherton
Copy link
Contributor Author

Just realised that I messed up the placeholders in the log message. I used JBoss logging style instead of SLF4J. I'll fix...

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I guess it might have already class some test resources.

@jamesnetherton jamesnetherton merged commit 7b9a771 into apache:main Jun 11, 2021
@jamesnetherton jamesnetherton deleted the portfinder-fix branch June 11, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants