Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace quarkus.camel.native.resources.* with quarkus.native.resource… #2813

Merged
merged 1 commit into from Jun 21, 2021
Merged

Replace quarkus.camel.native.resources.* with quarkus.native.resource… #2813

merged 1 commit into from Jun 21, 2021

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Jun 21, 2021

…s.* fix #988

jamesnetherton
jamesnetherton approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should do a scan of the example projects and clean this up over there too.

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 21, 2021

I guess we should do a scan of the example projects and clean this up over there too.

Indeed, I wanted to, ... and forgotten. Thanks for the reminder!

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 21, 2021

Fun fact: quarkus.native.resources.includes honors trailing white space in the value, while quarkus.camel.native.resources.include-patterns used to strip it. That's why the stringtemplate test failed.

aldettinger
aldettinger requested changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good to see this aligned on quarkus features 👍 I would just have few questions above.

@ppalaga ppalaga merged commit 16d09ea into apache:main Jun 21, 2021
@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 21, 2021

I guess we should do a scan of the example projects and clean this up over there too.

Indeed, I wanted to, ... and forgotten. Thanks for the reminder!

I checked and there were no occurrences of quarkus.camel.native.resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesnetherton jamesnetherton jamesnetherton approved these changes

@oscerd oscerd oscerd approved these changes

@aldettinger aldettinger aldettinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace quarkus.camel.native.resources.* with quarkus.native.resources.*
4 participants
@ppalaga @jamesnetherton @oscerd @aldettinger