Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read-lock tests #2889

Merged
merged 1 commit into from Aug 11, 2021
Merged

Fix read-lock tests #2889

merged 1 commit into from Aug 11, 2021

Conversation

philschaller
Copy link
Contributor

@aldettinger
Copy link
Contributor

@philschaller Many thanks for contributing to camel-quarkus 👍 Apparently, the fileReadLock_minLength test appears to fail on the continuous integration after this PR. When clicking the Details button on the Camel Quarkus CI / Native Tests - group-06 (pull_request) continuous integration check above, we notice the following log:

Error:  Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 24.713 s <<< FAILURE! - in org.apache.camel.quarkus.component.file.it.FileTest
Error:  fileReadLock_minLength  Time elapsed: 10.059 s  <<< FAILURE!
java.lang.AssertionError: 
1 expectation failed.
Expected status code <204> but was <200>.

@philschaller
Copy link
Contributor Author

@aldettinger The test will not pass until this Camel issue [1] is fixed. It should have caught that problem without the changes. But my first version of the test from last year was flawed.

[1] https://issues.apache.org/jira/browse/CAMEL-16795

@zbendhiba
Copy link
Contributor

@philschaller When your PR is merged in Camel, you can do this PR against camel-main branch, to be on 3.12.SNAPSHOT

@philschaller
Copy link
Contributor Author

@zbendhiba Fix for [1] has been merged into camel-main.

[1] https://issues.apache.org/jira/browse/CAMEL-16795

@ppalaga ppalaga changed the base branch from main to camel-main July 9, 2021 12:29
@ppalaga
Copy link
Contributor

ppalaga commented Jul 9, 2021

I have changed the base branch from main to camel-main

@github-actions github-actions bot force-pushed the camel-main branch 6 times, most recently from 5f1ac1e to c3c4bf0 Compare July 17, 2021 04:10
@zbendhiba zbendhiba force-pushed the camel-main branch 3 times, most recently from 5974f3d to c200d6d Compare August 6, 2021 08:48
@jamesnetherton jamesnetherton changed the base branch from camel-main to main August 10, 2021 13:02
@jamesnetherton
Copy link
Contributor

@philschaller Do you mind rebasing your branch with the latest work from main. We have upgraded to Camel 3.11.1.

@aldettinger
Copy link
Contributor

Many thanks @philschaller 👍

@aldettinger aldettinger merged commit 2a09b7b into apache:main Aug 11, 2021
@philschaller philschaller deleted the i2888 branch April 8, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants