Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camel-quarkus-minio: quarkus.minio.url is not mandatory #2911

Merged
merged 1 commit into from Jul 19, 2021

Conversation

JiriOndrusek
Copy link
Contributor

fixes #2721

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break any dependant project using quarkus extension as runtime. If I set the minio url at camel level in a kamelet I don't have to set the minio url as quarkus property.

@JiriOndrusek
Copy link
Contributor Author

@oscerd I'm not sure if I understand. My fix is only setting property ''quarkus.minio.allow-empty" to true, which has no effect on cases, where minio client is initialized from quarkus properties:

  • if all other quarkus minio parameters are null, no minio client will be created (without it, it would throw a validation exception)

From this perspective, everything that worked before, would work after this fix.
Only difference is in the case, where all quarkus parameters are null (url, server_secret and server_access) - case of kamelet - it wouldn't throw a validation exception, but return null as a client. Autowiring capability of the component then would use minio client from the context.

@JiriOndrusek
Copy link
Contributor Author

JiriOndrusek commented Jul 19, 2021

Better explanation of quarkus.minio.allow-empty is - do not throw a validation exception but return null as a minio client if al other parameters are null (so it won't throw an exception during autowiring, if all parameters are null)

@oscerd
Copy link
Contributor

oscerd commented Jul 19, 2021

The title was a bit misleading.. it looks like quarkus.minio.url is always mandatory, which should be wrong.

@JiriOndrusek
Copy link
Contributor Author

Sorry, I didn't see this, I'll change title.

@JiriOndrusek JiriOndrusek changed the title camel-quarkus-minio: quarkus.minio.url is mandatory and still has to be valid camel-quarkus-minio: quarkus.minio.url is not mandatory Jul 19, 2021
@ppalaga ppalaga merged commit e4a94be into apache:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

camel-quarkus-minio: "quarkus.minio.url" is mandatory and must be a valid url
3 participants