Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Quarkus to 2.1.1.Final #2986

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

@jamesnetherton
Copy link
Contributor Author

For anyone wondering about the formatting changes in pom.xml, it comes from running cq:sync-versions. Figured it was about time to commit them....

@@ -585,7 +585,7 @@
<executions>
<execution>
<id>default-test</id>
<phase /><!-- unbound here to speedup -Dquickly build; bound to a phase in camel-quarkus-build-parent-it -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should finally agree whether we want a space here or not :)

cq plugin mojos are currently set up to remove the spaces, but someone's IDE puts them back (isn't that you @jamesnetherton?) I can change the cq plugin to add the spaces if there's an agreement that it is prettier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it was modified in 09935b8.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, sorry for accusing you! Yeah, the spaces are added by mvn release:update-versions. Let me have a look what we can do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jdom2 used by the release plugin internally is very opinionated about this: https://github.com/hunterhacker/jdom/blob/master/core/src/java/org/jdom2/output/support/AbstractXMLOutputProcessor.java#L824 So I better adapt the cq plugin.

@jamesnetherton jamesnetherton merged commit b29c25f into apache:main Aug 4, 2021
@jamesnetherton jamesnetherton deleted the quarkus-2.1.1.Final branch August 4, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants