-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Quarkus to 2.1.1.Final #2986
Conversation
For anyone wondering about the formatting changes in |
@@ -585,7 +585,7 @@ | |||
<executions> | |||
<execution> | |||
<id>default-test</id> | |||
<phase /><!-- unbound here to speedup -Dquickly build; bound to a phase in camel-quarkus-build-parent-it --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should finally agree whether we want a space here or not :)
cq plugin mojos are currently set up to remove the spaces, but someone's IDE puts them back (isn't that you @jamesnetherton?) I can change the cq plugin to add the spaces if there's an agreement that it is prettier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was modified in 09935b8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ups, sorry for accusing you! Yeah, the spaces are added by mvn release:update-versions
. Let me have a look what we can do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jdom2 used by the release plugin internally is very opinionated about this: https://github.com/hunterhacker/jdom/blob/master/core/src/java/org/jdom2/output/support/AbstractXMLOutputProcessor.java#L824 So I better adapt the cq plugin.
No description provided.