New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sql - enable test with different databases #3053 #3066
Conversation
It could be possible to execute tests against several db types by default (at least dev-service db types which don't require license). What do you think about it, should it be investigated @ppalaga , @jamesnetherton ? |
integration-tests/sql/src/main/java/org/apache/camel/quarkus/component/sql/it/SqlRoutes.java
Outdated
Show resolved
Hide resolved
integration-tests/sql/src/test/java/org/apache/camel/quarkus/component/sql/it/SqlTest.java
Show resolved
Hide resolved
Probably, because otherwise we have a bunch of profiles that are never tested on CI. So there's a risk they get stale, stop working and nobody notices. Quarkus has |
I would say testing against each db types is up to quarkus. I think camel-sql is using jdbc, so nothing special per db types IMHO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, @JiriOndrusek! Some nitpicks inline.
integration-tests/sql/src/main/java/org/apache/camel/quarkus/component/sql/it/SqlHelper.java
Outdated
Show resolved
Hide resolved
integration-tests/sql/src/main/java/org/apache/camel/quarkus/component/sql/it/SqlRoutes.java
Outdated
Show resolved
Hide resolved
integration-tests/sql/src/main/java/org/apache/camel/quarkus/component/sql/it/SqlRoutes.java
Outdated
Show resolved
Hide resolved
integration-tests/sql/src/test/java/org/apache/camel/quarkus/component/sql/it/SqlTest.java
Outdated
Show resolved
Hide resolved
fa40d87
to
b9c6f13
Compare
@ppalaga , @aldettinger all requested changes are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nicer and I've also seen the stored proc part follow up issue #3080.
Well done for this PR @JiriOndrusek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JiriOndrusek looks very good, thanks. Could you please file the followup for running all the DB kind tests on the CI?
Issue #3083 created. |
fixes #3053
Adds a possibility to execute tests against different db types. The full list of supported databases follows (supported types are defined via jdbc extensions.)
Default behavior is not changed and
h2
in dev-service mode is used.If database can run in dev-service mode, it could be used. If environment variables are set, external db will be used. See more details in
README.adoc
file.Test for stored procedure is disabled for different types of db except
H2
- this could be fixed in the future.