Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salesforce : add Platform events test fixes #2938 #3068

Merged
merged 1 commit into from Sep 14, 2021

Conversation

zbendhiba
Copy link
Contributor

No description provided.

@XStreamConverter(MultiSelectPicklistConverter.class)
private Account_MyMultiselectEnum[] MyMultiselect__c;

@JsonProperty("MyMultiselect__c")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would these field removals regress #3022?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe we have something different in the settings of Salesforce account.
I need to regenerate the files with my account to get the Account class compatible with Salesforce API responses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the kind of error that I have if I run my tests with my account using actual code :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesnetherton Can you test with your account with just the commit including the test ? If you have some time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With your changes and the previous Account.java it seems to be working on my account. If I consume your changes to Account.java then I get the error outlined in #3022.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesnetherton Oh thanks. So let me revert those changes on Account.java, and SQL query.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesnetherton Oh thanks. So let me revert those changes on Account.java, and SQL query.

I mean the getbyQuery test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesnetherton It should be fine now

@ppalaga ppalaga merged commit 6b77c9e into apache:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants