Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed reference to Kamelets catalog #3070

Merged
merged 1 commit into from Sep 6, 2021
Merged

Fixed reference to Kamelets catalog #3070

merged 1 commit into from Sep 6, 2021

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Sep 6, 2021

Other part of #3069

@zbendhiba
Copy link
Contributor

It seems to me same as #3069 ?

@oscerd
Copy link
Contributor Author

oscerd commented Sep 6, 2021

One it's in the adoc from the main tree, the other one is the doc generation. I was from browser

aldettinger
aldettinger approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the doc reference needs to be corrected. However, it looks to me that #3069 and #3070 really points to the same change. Hence, it may be that there is no PR fixing the generated doc docs/modules/ROOT/pages/reference/extensions/kamelet.adoc at all.

@oscerd oscerd merged commit bc373b8 into main Sep 6, 2021
@oscerd
Copy link
Contributor Author

oscerd commented Sep 6, 2021

Sorry, I'll close the other one.

@jamesnetherton jamesnetherton deleted the kamelets-catalog-usage branch July 18, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbendhiba zbendhiba zbendhiba approved these changes

@aldettinger aldettinger aldettinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oscerd @zbendhiba @aldettinger