New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Salesforce testCDCAndStreamingEvents test to wait for consumin… #3105
Conversation
I don't know why the functional-extensions-tests-and-docs are failing. Do you think it's related to this PR, or do we have an issue ? |
I don't know too. But I think it's not related. It happened on other PRs as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation xref checks seem to have nothing to do with Camel Quarkus. I see only broken links in Camel and pointing to Camel. Can we safely ignore this, @zregvart?
For this PR I must say I do not understand how these changes fix the linked issue? You switched from a server side 10s await consumerTemplate.receiveBody()
to test side 10s polling which sounds like no substantial change. How is that addressing the wrong document due to test ordering?
The problem is not with the time, but what Account is consumed first. it's about testing the id of the account. If the consumers got the other account from another method first, the tests don't pass. So I wanted to poll multiple times until I get the right Account. |
@ppalaga well I've done multiple tests locally. It did poll until it finds the right Account, but sometimes 1000s is not enough to poll the first one. |
…g the right Document Fixes apache#3103
c0a8536
to
c925716
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, @zbendhiba makes sense
The netty failing tests seems not related to this |
I do not remember to have seen anything like that before. I have restarted the tests to see whether it persists. |
thanks @ppalaga |
…g the right Document
Fixes #3103