Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Salesforce testCDCAndStreamingEvents test to wait for consumin… #3105

Merged
merged 1 commit into from Sep 19, 2021

Conversation

zbendhiba
Copy link
Contributor

…g the right Document

Fixes #3103

@zbendhiba
Copy link
Contributor Author

I don't know why the functional-extensions-tests-and-docs are failing. Do you think it's related to this PR, or do we have an issue ?

@aldettinger
Copy link
Contributor

I don't know too. But I think it's not related. It happened on other PRs as well.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation xref checks seem to have nothing to do with Camel Quarkus. I see only broken links in Camel and pointing to Camel. Can we safely ignore this, @zregvart?

For this PR I must say I do not understand how these changes fix the linked issue? You switched from a server side 10s await consumerTemplate.receiveBody() to test side 10s polling which sounds like no substantial change. How is that addressing the wrong document due to test ordering?

@ppalaga
Copy link
Contributor

ppalaga commented Sep 16, 2021

The documentation xref checks seem to have nothing to do with Camel Quarkus. I see only broken links in Camel and pointing to Camel. Can we safely ignore this, @zregvart?

Unping @zregvart, sorry for disturbing, it looks like there is a solution already: #3110

@zbendhiba
Copy link
Contributor Author

The documentation xref checks seem to have nothing to do with Camel Quarkus. I see only broken links in Camel and pointing to Camel. Can we safely ignore this, @zregvart?

For this PR I must say I do not understand how these changes fix the linked issue? You switched from a server side 10s await consumerTemplate.receiveBody() to test side 10s polling which sounds like no substantial change. How is that addressing the wrong document due to test ordering?

The problem is not with the time, but what Account is consumed first. it's about testing the id of the account. If the consumers got the other account from another method first, the tests don't pass. So I wanted to poll multiple times until I get the right Account.
Is that make sense ?

@zbendhiba
Copy link
Contributor Author

@ppalaga well I've done multiple tests locally. It did poll until it finds the right Account, but sometimes 1000s is not enough to poll the first one.
So I'm going to add more time to the consumer

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, @zbendhiba makes sense

@zbendhiba
Copy link
Contributor Author

The netty failing tests seems not related to this

@ppalaga
Copy link
Contributor

ppalaga commented Sep 19, 2021

The netty failing tests seems not related to this

I do not remember to have seen anything like that before. I have restarted the tests to see whether it persists.

@aldettinger aldettinger merged commit f4f992f into apache:main Sep 19, 2021
@zbendhiba zbendhiba deleted the 3103-salesforce branch September 20, 2021 07:31
@zbendhiba
Copy link
Contributor Author

thanks @ppalaga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Salesforce integration tests: possible failures
4 participants