Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer example #312

Merged
merged 4 commits into from Oct 22, 2019
Merged

Timer example #312

merged 4 commits into from Oct 22, 2019

Conversation

davsclaus
Copy link
Contributor

No description provided.

@davsclaus
Copy link
Contributor Author

@lburgazzoli the are some options in application.properties - such as the dump route. Not sure if they are working or have changed name? I dont see any dumped route (I assume its disabled as it may require JAXB/XML). If so we can remove the cruft from this file to make it minimal.

ppalaga
ppalaga reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions inline.

examples/timer-log/README.adoc Outdated Show resolved Hide resolved
examples/timer-log/README.adoc Outdated Show resolved Hide resolved
@ppalaga
Copy link
Contributor

ppalaga commented Oct 22, 2019

dump route. Not sure if they are working or have changed name? I dont see any dumped route (I assume its disabled as it may require JAXB/XML). If so we can remove the cruft from this file to make it minimal.

Good catch. org.apache.camel.quarkus.core.CamelConfig.Runtime.dumpRoutes still exists, but is unused. I think it can be removed. There is enough route status messages logged even without that.

davsclaus and others added 2 commits October 22, 2019 12:55
@davsclaus
#310: Polished
dec48ea
@davsclaus @ppalaga
Update examples/timer-log/README.adoc
f13fbd6 
Co-Authored-By: Peter Palaga <ppalaga@redhat.com>
@asf-ci
Copy link

asf-ci commented Oct 22, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/298/

@davsclaus davsclaus merged commit 21544b2 into master Oct 22, 2019
@davsclaus davsclaus deleted the timer-example branch October 22, 2019 13:04
@asf-ci
Copy link

asf-ci commented Oct 22, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/300/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppalaga ppalaga ppalaga approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davsclaus @ppalaga @asf-ci @oscerd