Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3157 to make sure the brokers option is configured in native mode #3198

Merged
merged 2 commits into from Oct 20, 2021

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Oct 19, 2021

No description provided.

Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - I completely missed DevServicesConfigResultBuildItem.

@jamesnetherton
Copy link
Contributor

Just noticed that the functional-extension-tests-and-docs build is failing with an error probably related to this change.

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @zhfeng and many thanks for explaining the issue in the ticket 👍

@zhfeng
Copy link
Contributor Author

zhfeng commented Oct 19, 2021

@jamesnetherton I'm checking the failure tests.

@zhfeng
Copy link
Contributor Author

zhfeng commented Oct 19, 2021

@jamesnetherton The KafkaDevServicesEnabledTest is running before KafkaDevServicesDisabledTest, and it config camel.component.kafka.brokers in the properties. I just commit a fix to override it with empty value in KafkaDevServicesDisabledTest. Is there any other better solution ? or any way to clean the propeties after KafkaDevServicesEnabledTest ?

@jamesnetherton
Copy link
Contributor

jamesnetherton commented Oct 19, 2021

@zhfeng I thought each test effectively runs in insolation. I.e each test is its own Quarkus application. If so, the order of tests should not matter.

If the camel kafka brokers config is set even when kafka dev services is disabled, then it means there is a bug somewhere.

@zhfeng
Copy link
Contributor Author

zhfeng commented Oct 20, 2021

@jamesnetherton I create the following #3206 to keep invesigating the failure test and since the workaround to override the property works, I'd like to merge this PR first.

@zhfeng zhfeng merged commit 0caa4c4 into apache:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants