New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3157 to make sure the brokers option is configured in native mode #3198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix - I completely missed DevServicesConfigResultBuildItem
.
Just noticed that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @zhfeng and many thanks for explaining the issue in the ticket 👍
@jamesnetherton I'm checking the failure tests. |
@jamesnetherton The |
@zhfeng I thought each test effectively runs in insolation. I.e each test is its own Quarkus application. If so, the order of tests should not matter. If the camel kafka brokers config is set even when kafka dev services is disabled, then it means there is a bug somewhere. |
@jamesnetherton I create the following #3206 to keep invesigating the failure test and since the workaround to override the property works, I'd like to merge this PR first. |
No description provided.