Fix #322 Make camel-attachments an optional dependency of platform-http #323
Conversation
...s/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
Outdated
Show resolved
Hide resolved
ppalaga
force-pushed
the
i322
branch
2 times, most recently
from
673560c
to
da06f3f
Compare
|
da06f3f :
|
|
7dce10b Added the since versions fix |
|
Refer to this link for build results (access rights to CI server needed): |
|
d0e1398 a dummy change to restart the CI |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
The PR https://builds.apache.org/job/camel-quarkus-pr/313/ passed |
|
@lburgazzoli is this good to merge now? |
...untime/src/main/java/org/apache/camel/quarkus/component/attachments/AttachmentsRecorder.java
Show resolved
Hide resolved
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/UploadAttacher.java
Show resolved
Hide resolved
My understanding is that as long as the PR CI does not enforce the license headers they are optional for common commits. They are only required for releases. |
Please add the ASF license headers. They are optional if nobody spotted them, someone spotted them (thanks @jamesnetherton ) and it's better to add them, instead of having to add a bunch of license headers during the release process. |
|
So, when we find codestyle or missing headers, it always better to fix the situation at the moment, otherwise we could forget about it |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 1.05 MB...] at java.lang.reflect.Method.invoke (Method.java:498) at hudson.maven.Maven3Builder.call (Maven3Builder.java:139) at hudson.maven.Maven3Builder.call (Maven3Builder.java:70) at hudson.remoting.UserRequest.perform (UserRequest.java:212) at hudson.remoting.UserRequest.perform (UserRequest.java:54) at hudson.remoting.Request$2.run (Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call (InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run (FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:624) at java.lang.Thread.run (Thread.java:748)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-docschannel stoppedAdding one-line test results to commit status...Setting status of da06f3f to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/314/ and message: 'FAILURE 123 tests run, 4 skipped, 0 failed.'Using context: default |
|
Fixed the missing license headers and added more platform-http tests in d391f4f |
|
I cannot stand the feeling that checking the style manually is wasting of time of both reviewers and PR authors. Yes, I can alias my maven to do the checks locally, but due to that, I'll just end up fixing someone else's style violations, because non-compliant code is commonly committed. I vote for everybody fixing these little things before submitting and the default Maven build and CI enforcing them. That would be less work for both PR authors and reviewers. |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 1.40 MB...] at sun.reflect.GeneratedMethodAccessor220.invoke (Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:498) at io.quarkus.deployment.ExtensionLoader$1.execute (ExtensionLoader.java:940) at io.quarkus.builder.BuildContext.run (BuildContext.java:415) at org.jboss.threads.ContextClassLoaderSavingRunnable.run (ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads.EnhancedQueueExecutor.safeRun (EnhancedQueueExecutor.java:2011) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask (EnhancedQueueExecutor.java:1535) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run (EnhancedQueueExecutor.java:1426) at java.lang.Thread.run (Thread.java:748) at org.jboss.threads.JBossThread.run (JBossThread.java:479)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-integration-test-corechannel stoppedAdding one-line test results to commit status...Setting status of 7dce10b to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/315/ and message: 'FAILURE 70 tests run, 2 skipped, 0 failed.'Using context: default |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 1camel-quarkus-pr/org.apache.camel.quarkus:camel-quarkus-integration-test-platform-http: 1 |
ppalaga
force-pushed
the
i322
branch
2 times, most recently
from
c13bf45
to
0f30536
Compare
|
0f30536 fixed the failing encoding test in the native mode. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
The Jenkins nodes without Maven feel like Russian roulette :-/ |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 1.39 MB...] at sun.reflect.GeneratedMethodAccessor219.invoke (Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:498) at io.quarkus.deployment.ExtensionLoader$1.execute (ExtensionLoader.java:940) at io.quarkus.builder.BuildContext.run (BuildContext.java:415) at org.jboss.threads.ContextClassLoaderSavingRunnable.run (ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads.EnhancedQueueExecutor.safeRun (EnhancedQueueExecutor.java:2011) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask (EnhancedQueueExecutor.java:1535) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run (EnhancedQueueExecutor.java:1426) at java.lang.Thread.run (Thread.java:748) at org.jboss.threads.JBossThread.run (JBossThread.java:479)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-integration-test-corechannel stoppedAdding one-line test results to commit status...Setting status of c13bf45 to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/323/ and message: 'FAILURE 76 tests run, 3 skipped, 0 failed.'Using context: default |
|
Refer to this link for build results (access rights to CI server needed): |
|
The CI passed finally. Is this good to merge? |
...nsions/core/runtime/src/main/java/org/apache/camel/quarkus/core/CoreAttachmentsRecorder.java
Outdated
Show resolved
Hide resolved
...va/org/apache/camel/quarkus/component/platform/http/runtime/QuarkusPlatformHttpConsumer.java
Show resolved
Hide resolved
|
5a40b6f addressed the comments of @lburgazzoli |
|
ok to test |
No description provided.