Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed anymore BeansWeakCache substitution. Closes #3226 #3264

Merged
merged 1 commit into from Nov 5, 2021

Conversation

vladimirfx
Copy link
Contributor

@vladimirfx vladimirfx commented Nov 4, 2021

Fix for #3226
Tested locally on a couple of Camel Quarkus projects:

Quarkus 2.4.1.Final

ubi-quarkus-native-image:21.2-java11
ubi-quarkus-native-image:21.3-java17
ubi-quarkus-native-image:21.3-java11

@vladimirfx
Copy link
Contributor Author

There is some special build step that I forget to do?

@zhfeng
Copy link
Contributor

zhfeng commented Nov 4, 2021

It's werid that qute.json got some changes. I'll take a look.

@zhfeng
Copy link
Contributor

zhfeng commented Nov 4, 2021

@vladimirfx what are the steps you used to verify locally ? I think it should run all intgration tests in native mode.

@zhfeng
Copy link
Contributor

zhfeng commented Nov 4, 2021

@vladimirfx I think you need to raise a PR agaist to main branch but not 2.4.x branch.

@vladimirfx
Copy link
Contributor Author

@vladimirfx what are the steps you used to verify locally ? I think it should run all intgration tests in native mode.

I run full non native build locally and test resulting artifacts on own projects.

@oscerd oscerd self-requested a review November 4, 2021 14:23
@oscerd
Copy link
Contributor

oscerd commented Nov 4, 2021

Yeah, it should be against main

@vladimirfx
Copy link
Contributor Author

@vladimirfx I think you need to raise a PR agaist to main branch but not 2.4.x branch.

OK... but I can practically check it againts 2.4 releases only.

@vladimirfx
Copy link
Contributor Author

Rebased on main.

@aldettinger
Copy link
Contributor

I've checked locally that native tests succeed against few select project. But better wait for a full CI build to approve.

@zhfeng zhfeng merged commit 2874a60 into apache:main Nov 5, 2021
@vladimirfx vladimirfx deleted the 3226 branch November 5, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants