Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DebeziumMongodbTest skipped tests #3213 #3266

Merged
merged 1 commit into from Feb 11, 2022

Conversation

JiriOndrusek
Copy link
Contributor

fixes #3213

Problem was caused by https://github.com/quarkusio/quarkus/pull/16748/files, which made some of the test disabled forever. I refactored the way how tests are disabled, using ConfigProvider.getConfig().

@aldettinger
Copy link
Contributor

@JiriOndrusek Not sure I get it. Shouldn't we fail when the mySql driver is not there or the Ms SQL EULA has not accepted ?

I see it like they are part of the valid test setup, but maybe I'm missing something there ?

@JiriOndrusek
Copy link
Contributor Author

JiriOndrusek commented Nov 4, 2021

@aldettinger Original behavior was, that if driver is missing or EULA is not accepted, those tests will be skipped. It makes sense, because on CI we won't have driver or acceptance of EULA. This PR doesn't change the behavior, only fixes issues. (because without this fix, mysql, mssql and mongo will be skipped always).

Edited:
Because skipping was based on the presence of system properties, which are now never there (https://github.com/quarkusio/quarkus/pull/16748/files)

Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's clearer now. The failing test on CI seems unrelated. Well done @JiriOndrusek :)

@ppalaga
Copy link
Contributor

ppalaga commented Feb 9, 2022

Ups, it looks like this PR got forgotten for some reason. Could you please rebase @JiriOndrusek ?

@JiriOndrusek
Copy link
Contributor Author

@ppalaga rebased

@ppalaga
Copy link
Contributor

ppalaga commented Feb 10, 2022

@JiriOndrusek could you please have a look at the failure and assess whether they may be caused by this change?

@JiriOndrusek
Copy link
Contributor Author

This PR modifies only 3 test files inside inegration-tests/debezium Failure is caused by JmsArtemisTest.

 JmsArtemisTest>AbstractMessagingTest.testResequence:140 1 expectation failed.

I don't see a possible connection to the changed files.

@ppalaga ppalaga merged commit 64a18af into apache:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DebeziumMongodbTest skipped tests
4 participants