New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DebeziumMongodbTest skipped tests #3213 #3266
Conversation
@JiriOndrusek Not sure I get it. Shouldn't we fail when the mySql driver is not there or the Ms SQL EULA has not accepted ? I see it like they are part of the valid test setup, but maybe I'm missing something there ? |
@aldettinger Original behavior was, that if driver is missing or EULA is not accepted, those tests will be skipped. It makes sense, because on CI we won't have driver or acceptance of EULA. This PR doesn't change the behavior, only fixes issues. (because without this fix, mysql, mssql and mongo will be skipped always). Edited: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's clearer now. The failing test on CI seems unrelated. Well done @JiriOndrusek :)
b8d1c9c
to
50a1de6
Compare
Ups, it looks like this PR got forgotten for some reason. Could you please rebase @JiriOndrusek ? |
50a1de6
to
82698f1
Compare
@ppalaga rebased |
@JiriOndrusek could you please have a look at the failure and assess whether they may be caused by this change? |
This PR modifies only 3 test files inside
I don't see a possible connection to the changed files. |
fixes #3213
Problem was caused by https://github.com/quarkusio/quarkus/pull/16748/files, which made some of the test disabled forever. I refactored the way how tests are disabled, using
ConfigProvider.getConfig()
.