Sql doc update because of the failure with external oracle database #… #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Nov 5, 2021
zbendhiba
approved these changes
Nov 5, 2021
aldettinger
reviewed
Nov 5, 2021
aldettinger
reviewed
Nov 5, 2021
aldettinger
approved these changes
Nov 5, 2021
JiriOndrusek
force-pushed
the
3256-sql-oracle-native-limitations
branch
from
0e198cf
to
da6fc1c
Compare
ppalaga
reviewed
Nov 11, 2021
|
@JiriOndrusek A small up on this PR. My understanding is that it just needs few fixes ? Or am I missing some context ? |
|
@aldettinger Yes you are right, only small fixes (mainly doc) is need to be done. edited: I should fix it today. |
JiriOndrusek
force-pushed
the
3256-sql-oracle-native-limitations
branch
2 times, most recently
from
beb42f5
to
2af16c1
Compare
JiriOndrusek
force-pushed
the
3256-sql-oracle-native-limitations
branch
from
2af16c1
to
7e9035c
Compare
|
@aldettinger PR is fixed, it could be merged. |
|
@JiriOndrusek @ppalaga Thanks all. Sorry for this late comment. It turns out that quarkusio/quarkus#20396 was fixed in the mean time. My understanding is that we still have #3256 to manage it on our side, so that's ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc update for (does not fix the issue) #3256