Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Set documentation version to Camel Quarkus 2.5.x #3339

Merged
merged 1 commit into from
Nov 27, 2021

Conversation

zbendhiba
Copy link
Contributor

No description provided.

@zbendhiba
Copy link
Contributor Author

I wonder if this one works as this apache/camel-website#691 not merged yet

@zbendhiba
Copy link
Contributor Author

I fixed the qute.json file
But I'm skeptical that this could work. Every time I build the project, the antora.yaml file is updated. The version goes from 2.5.x to next. So I'm expecting the mvn install to fail.

@jamesnetherton
Copy link
Contributor

The version goes from 2.5.x to next.

Ah yeah the update script sees SNAPSHOT in the project version and will use next.

I think we should just merge this PR. It's pretty unlikely anyone is going to do a full build the 2.5.x anyway. We can fix up the antora update script and try to make it smarter later.

@djencks
Copy link
Contributor

djencks commented Nov 27, 2021

For 2.4.x I updated the groovy scripts to not update antora.yml: efda8ea

I'd recommend doing that here too.

@zbendhiba
Copy link
Contributor Author

I don't know how we could address this in the release process. Is there a way to change automagically those files ?

@zbendhiba
Copy link
Contributor Author

I guess I can merge this. Thanks for reviews

@zbendhiba zbendhiba merged commit 2061e65 into apache:2.5.x Nov 27, 2021
@djencks
Copy link
Contributor

djencks commented Nov 27, 2021

I couldn't think of an automated way of detecting a non-next branch.

Would it be possible for the release process to add a pom property saying "released" and the groovy script not update the Antora stuff on a released branch?

@ppalaga
Copy link
Contributor

ppalaga commented Nov 29, 2021

Could please somebody create an issue describing what should happen on release?

@zbendhiba
Copy link
Contributor Author

@ppalaga Yes, I'd create one to explain all I did. on my TODO list

@ppalaga
Copy link
Contributor

ppalaga commented Dec 2, 2021

For the record, the issue is here: #3350

@zbendhiba zbendhiba deleted the cq-2.5.x-doc branch January 24, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants