Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent version of software.amazon.awssdk dependencies #3371

Merged
merged 1 commit into from Dec 9, 2021

Conversation

jamesnetherton
Copy link
Contributor

Since the move of Quarkus Amazon Services to Quarkiverse & given the dependency management issues I mentioned here and here, I don't see a better way of ensuring we are using a consistent & known version of the AWS dependencies.

Alternatively, I could move this BOM import into camel-quarkus-bom. But quarkus-amazon-services-bom also includes the Quarkus AWS extensions, and I don't think we want those being imported into our core BOM. Hence I opted to import the plain software.amazon.awssdk BOM.

@zbendhiba
Copy link
Contributor

zbendhiba commented Dec 9, 2021

@jamesnetherton For my understanding, this imports the software.amazon.awssdk version of Quarkiverse only for the tests ?

@jamesnetherton
Copy link
Contributor Author

@jamesnetherton For my understanding, this imports the software.amazon.awssdk version of Quarkiverse only for the tests ?

No, also for non-test usage too. I.e so that our Camel AWS extensions use a consistent version for all software.amazon.awssdk dependencies.

We only import quarkus-amazon-services-bom in camel-quarkus-bom-test because we have these aws2-quarkus-client tests, and they need access to the Quarkiverse AWS extensions.

Hope that makes sense.

@zbendhiba
Copy link
Contributor

@jamesnetherton For my understanding, this imports the software.amazon.awssdk version of Quarkiverse only for the tests ?

No, also for non-test usage too. I.e so that our Camel AWS extensions use a consistent version for all software.amazon.awssdk dependencies.

We only import quarkus-amazon-services-bom in camel-quarkus-bom-test because we have these aws2-quarkus-client tests, and they need access to the Quarkiverse AWS extensions.

Hope that makes sense.

ok, I think what disturbs me is the comment to sync from Quarkiverse. But I guess, since Amazon services are part of the Quarkus platform, I guess you're right, this is the version to sync from.

@jamesnetherton jamesnetherton merged commit 77cee83 into apache:main Dec 9, 2021
@jamesnetherton jamesnetherton deleted the manage-aws-deps branch December 9, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants