Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC/WIP local build setup #3385

Merged
merged 1 commit into from Dec 16, 2021
Merged

POC/WIP local build setup #3385

merged 1 commit into from Dec 16, 2021

Conversation

djencks
Copy link
Contributor

@djencks djencks commented Dec 15, 2021

@aldettinger
Copy link
Contributor

@djencks I don't know the doc part that much and can't run it locally because of setup issues. Yet, let me do my best to review.
One question thought, is there a simple way to double check that this PR does not break the doc ?

@djencks
Copy link
Contributor Author

djencks commented Dec 15, 2021

@djencks I don't know the doc part that much and can't run it locally because of setup issues. Yet, let me do my best to review.

Could you elaborate on the setup issues? The instructions are in my dev list post on local partial builds. If the instructions are unclear or don't work I'd like to know :-)

One question thought, is there a simple way to double check that this PR does not break the doc ?

I'm not quite sure what you are asking. The only sure way to check is to do a website PR build as described here: https://camel.apache.org/manual/improving-the-documentation.html#_creating_a_documentation_pull_request. Unfortunately this is not simple :-) Doing a "full local build" as described in the dev list post is almost as good and much simpler. However, since the changes here don't change anything about the stuff used in the actual website build, they are unlikely to break it.

@aldettinger
Copy link
Contributor

@djencks the setup issue on my machine has no link with this specific PR. It's just I can't generate the doc locally independent from this PR.

I was asking a bout a simple way to check the PR. And it looks there is not. So I guess it's ok to merge and see how it's going :)

fix tooling enough so it doesn't break build
@djencks djencks merged commit 43cede1 into apache:main Dec 16, 2021
@djencks djencks deleted the main-local-build branch December 16, 2021 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants