Improve camel service discovery and filtering #340
Conversation
…rvices automatically discovered and instantiated at augmentation phase
|
Refer to this link for build results (access rights to CI server needed): |
| import java.util.function.Predicate; | ||
|
|
||
| @FunctionalInterface | ||
| public interface CamelServiceFilter extends Predicate<CamelServiceInfo> { |
There was a problem hiding this comment.
I fail to see what value is CamelServiceFilter interface adding. I'd personally prefer using Predicate<CamelServiceInfo> directly because that way I'd immediately see that it is just a Predicate and nothing else.
| import io.quarkus.builder.item.MultiBuildItem; | ||
| import org.apache.camel.quarkus.core.CamelServiceFilter; | ||
|
|
||
| public final class CamelServiceFilterBuildItem extends MultiBuildItem { |
There was a problem hiding this comment.
I'd like us all to document BuildItems properly. The class level BuildItem JavaDoc should make the extension developers understand what is the purpose of the given BuildItem and when/how they should use it. If we provide no JavaDoc, the extension developers are doomed to click through our BuildProcessors and collect the information investing a lot more effort.
No description provided.