Update CamelRoute.java #3408
Closed
Update CamelRoute.java #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change delay to 20000 (20 seconds) to allow the application.properties camel.main.durationMaxSeconds (set at 10 seconds) to stop the JVM before the timer kicks in
|
@gus-maurizio Many thanks for stepping in. Contributions from all around the world are welcomed :) It looks that this PR is not reproducing #3394 yet as the CI checks report green. By any chance, have you changed |
|
Thanks Alexandre. Not sure how to reproduce the issue of something that is not working. The PR shows it is not working, since the whole exchange should terminate when maxDuration is reached but does not. Any ideas?
…Sent from my iPad
On Jan 3, 2022, at 5:13 AM, Alexandre Gallice ***@***.***> wrote:
@gus-maurizio Many thanks for stepping in. Contributions from all around the world are welcomed :)
It looks that this PR is not reproducing #3394 yet as the CI checks report green. By any chance, have you changed application.properties locally to reproduce the issue ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
|
@gus-maurizio I was not able to reproduce any issue with this PR. This PR merely change the value of delay from -1 to -20000. As far as I know, the behavior of the timer component is the same with both values. A bit of exploration around |
|
Yes. That makes sense.
G
… On Jan 3, 2022, at 11:40 AM, Alexandre Gallice ***@***.***> wrote:
@gus-maurizio I was not able to reproduce any issue with this PR. This PR merely change the value of delay from -1 to -20000. As far as I know, the behavior of the timer component is the same with both values.
A bit of exploration around durationMaxMessage may show a bug in #3434.
Are you ok to close this PR is favor of #3434 ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change delay to 20000 (20 seconds) to allow the application.properties camel.main.durationMaxSeconds (set at 10 seconds) to stop the JVM before the timer kicks in
A reproducer for #3394