Aws2 quarkus client ddb refactor #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 17, 2022
|
I'm not sure whether this PR contains both ddb and S3 ? Shouldn't we merge #3458 first ? Or maybe rebase ? |
|
@aldettinger Yes. #3458 should be merged first. Hopefully there should not be needed any rebase of this PR, because the first commit is the same in both PRs. I wrote that into the summary: |
|
@JiriOndrusek I've merged the other PR and now this one has conflict. Could you please check ? |
|
I'll do it |
JiriOndrusek
force-pushed
the
aws2--quarkus-client-ddb-refactor
branch
from
837962d
to
94f267b
Compare
|
@aldettinger it should be fixed. Eventhough I cherrypicked the second commitr from the original PR and there was no conflict. I'm not sure why it didn't work automatically |
|
I don't know too. Let's have a successful CI build and merge this PR then. Thanks for fixing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3236
Requires #3458 to be merged (it contains the forst commit from this PR)
This commit refactores aws2-quarkus-client-ddb. With this change, module will copy sources from aws2-ddb module and won't duplicate them.
S3 module is fixed by the PR which contains the first commit.