Upgrade formatter-maven-plugin to 2.17.1 #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Feb 2, 2022
ppalaga
reviewed
Feb 2, 2022
poms/build-parent/pom.xml
Outdated
| @@ -97,6 +97,7 @@ | |||
| <version>${formatter-maven-plugin.version}</version> | |||
| <configuration> | |||
| <configFile>${maven.multiModuleProjectDirectory}/tooling/eclipse-formatter-config.xml</configFile> | |||
| <lineEnding>KEEP</lineEnding> | |||
There was a problem hiding this comment.
What's the meaning of this change? Would the plugin keep Windows EOLs if end users enter them?
There was a problem hiding this comment.
Would the plugin keep Windows EOLs if end users enter them?
Yes. On previous versions of the plugin, it blindly reformats everything with the users platform line ending. Resulting in the entire git source tree being modified.
There was a problem hiding this comment.
Oh really? Keep is certainly better than user's platform. Is there no way to force Unix EOLs?
There was a problem hiding this comment.
Is there no way to force Unix EOLs?
Yes, I guess it'd make more sense to use <lineEnding>LF</lindending>.
There was a problem hiding this comment.
Latest commit forces Unix EOLs.
jamesnetherton
force-pushed
the
upgrade-fmp
branch
from
937cd7b
to
0a6ddf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.