Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camel quarkus netty #353

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Conversation

dhartford
Copy link

#248 initial support for camel-quarkus-netty

.gitignore Show resolved Hide resolved
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff, I guess you'll need to run the build with sourcecheck profile enabled and check for warnings

@oscerd
Copy link
Contributor

oscerd commented Oct 30, 2019

And by the way you have conflicts need to be fixed.

@asf-ci
Copy link

asf-ci commented Oct 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/362/

@asf-ci
Copy link

asf-ci commented Oct 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/363/

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks!

Some comments inline. Please rebase and squash your commits.

@asf-ci
Copy link

asf-ci commented Oct 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/364/

@oscerd
Copy link
Contributor

oscerd commented Oct 30, 2019

#353 (comment)

Thanks for pointing this out. It's not documented.

@asf-ci
Copy link

asf-ci commented Oct 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/365/

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments inline.

docs/modules/ROOT/pages/extensions/netty.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/extensions/netty.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/extensions/netty.adoc Outdated Show resolved Hide resolved
@ppalaga
Copy link
Contributor

ppalaga commented Oct 30, 2019

#353 (comment)

Thanks for pointing this out. It's not documented.

True. Let me doc it #354

.gitignore Outdated
@@ -19,7 +19,7 @@ bin/
*.iws

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always for removing the gitignore file.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments inline.

@asf-ci
Copy link

asf-ci commented Oct 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/367/

@asf-ci
Copy link

asf-ci commented Oct 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/368/

@asf-ci
Copy link

asf-ci commented Oct 31, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/369/

Build result: FAILURE

[...truncated 1.58 MB...] at sun.reflect.GeneratedMethodAccessor237.invoke (Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:498) at io.quarkus.deployment.ExtensionLoader$1.execute (ExtensionLoader.java:941) at io.quarkus.builder.BuildContext.run (BuildContext.java:415) at org.jboss.threads.ContextClassLoaderSavingRunnable.run (ContextClassLoaderSavingRunnable.java:35) at org.jboss.threads.EnhancedQueueExecutor.safeRun (EnhancedQueueExecutor.java:2011) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask (EnhancedQueueExecutor.java:1535) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run (EnhancedQueueExecutor.java:1426) at java.lang.Thread.run (Thread.java:748) at org.jboss.threads.JBossThread.run (JBossThread.java:479)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-integration-test-corechannel stoppedAdding one-line test results to commit status...Setting status of e4a98a6 to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/369/ and message: 'FAILURE 96 tests run, 2 skipped, 0 failed.'Using context: default

@asf-ci
Copy link

asf-ci commented Oct 31, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/370/

@asf-ci
Copy link

asf-ci commented Oct 31, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/371/

@dhartford dhartford reopened this Oct 31, 2019
@dhartford
Copy link
Author

Adding comment to this ticket (already shared on https://gitter.im/apache/camel-quarkus), had some challenges with the rebase/squash operations and instead needed to recover and re-commit the branch, as such some of the references in the code reviews may unfortunately not work as expected.

@asf-ci
Copy link

asf-ci commented Oct 31, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/372/

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

Some comments inline.

Please run mvn clean install -DskipTests from the root dir once again and amend the changes in list-of-camel-quarkus-extensions.adoc

There are some duplications between netty and netty-http components now. In a follow up step, we should make netty-http dependent on netty and remove the dups. We should also document in the netty.adoc that the native transport is not supported in the native mode. I'll create issues for these.

extensions/netty/runtime/pom.xml Outdated Show resolved Hide resolved
extensions/netty/runtime/pom.xml Outdated Show resolved Hide resolved
extensions/netty/runtime/pom.xml Outdated Show resolved Hide resolved
extensions/netty/deployment/pom.xml Show resolved Hide resolved
integration-tests/netty/pom.xml Outdated Show resolved Hide resolved
integration-tests/netty/pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just two details: (1) remove camel-endpointdsl from poms/bom/pom.xml and (2) squash your commits. Otherwise, the PR is good to merge.

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@dhartford dhartford requested a review from oscerd October 31, 2019 20:20
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the gitignore

@oscerd
Copy link
Contributor

oscerd commented Oct 31, 2019

Sorry just realised it's a gitignore already there. Sorry. Looks good

@asf-ci
Copy link

asf-ci commented Oct 31, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/375/

@asf-ci
Copy link

asf-ci commented Oct 31, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/376/

@asf-ci
Copy link

asf-ci commented Oct 31, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/377/

@lburgazzoli lburgazzoli merged commit 6186777 into apache:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants