Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #354 Update contributor guide: s/json/yaml/, extension adoc page #355

Merged
merged 1 commit into from Oct 31, 2019

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Oct 30, 2019

No description provided.

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 30, 2019

@dhartford now that you freshly passed the journey, do you have any suggestions how we could further improve the Contributor guide?

@asf-ci
Copy link

asf-ci commented Oct 30, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/366/

@dhartford
Copy link

@ppalaga The only two areas I can think of would be:

  1. Reference how to safely git rebase/squash commits before a PR. There are a lot of references on the internet, however not all are made equal as I found out.

  2. A starter-guide for how to identify classes that need special reflection handling for GraalVM/native builds. I know that isn't necessarily camel-specific, but likely to have a lot of experienced java developers that want to contribute that will be in the dark with that item.

I appreciate the addition to the contributor guide for mvn validate -Plicense,sourcecheck -Dcheckstyle.failOnViolation=true

@dhartford
Copy link

Cross-check: For all the references for -Pnative, do you mean -Dnative? I just tested and there aren't any native profiles yet, just the native flag for activation.

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 31, 2019

Cross-check: For all the references for -Pnative, do you mean -Dnative? I just tested and there aren't any native profiles yet, just the native flag for activation.

Good catch, thanks, the profile is called native-image let me fix it.

@lburgazzoli lburgazzoli merged commit 80ef8f7 into apache:master Oct 31, 2019
@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 1, 2019

Ups, this got merged before I fixed the issue reported by @dhartford . Let me send a followup PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants