Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝Slack test : update Readme with new Oauth Configuration #3620

Merged
merged 2 commits into from Mar 15, 2022

Conversation

zbendhiba
Copy link
Contributor

No description provided.

@zbendhiba zbendhiba marked this pull request as draft March 14, 2022 20:09
@zbendhiba
Copy link
Contributor Author

Oh I forgot something to add for this one

@zbendhiba
Copy link
Contributor Author

I've changed the channel name, as I had some issues with French name of the #3531 general channel

…annel name that isn't dependent on user slack language
@zbendhiba zbendhiba marked this pull request as ready for review March 15, 2022 08:07
Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo nitpick. Otherwise LGTM.

integration-tests/slack/README.adoc Outdated Show resolved Hide resolved
Co-authored-by: James Netherton <jamesnetherton@users.noreply.github.com>
@zbendhiba
Copy link
Contributor Author

Small typo nitpick. Otherwise LGTM.

Thanks !!

@zbendhiba zbendhiba merged commit e60c2f7 into apache:main Mar 15, 2022
@zbendhiba zbendhiba deleted the slack-doc branch March 15, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants