Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camel quarkus 3532 #3639

Merged
merged 3 commits into from Mar 18, 2022
Merged

Camel quarkus 3532 #3639

merged 3 commits into from Mar 18, 2022

Conversation

aldettinger
Copy link
Contributor

No description provided.

jamesnetherton
jamesnetherton reviewed Mar 18, 2022
View reviewed changes
Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with it. But, since we're not doing an announcement for 2.8.0-M1 and its not being released on the platform, I don't think we've publicised that these extensions are going to be removed. So we should at least drop a note into the 2.8.0 migration guide.

@aldettinger
Copy link
Contributor Author

aldettinger commented Mar 18, 2022 •
edited

Yes indeed.

Another point, I was also thinking about the 2.7.x branch. Those extensions were also half removed in the 2.7.x branch.

So, I guess they would disappear in 2.7.1 anyway. And so, this PR would need to be backported in 2.7.x also. But it's like removing extensions from an LTS branch that one could expect to be stable.

@jamesnetherton
Copy link
Contributor

this PR would need to be backported in 2.7.x also

The alternative would be to revert the removal commit on 2.7.x and reinstate the extensions.

@aldettinger
Copy link
Contributor Author

this PR would need to be backported in 2.7.x also

The alternative would be to revert the removal commit on 2.7.x and reinstate the extensions.

Ok, let's do that. It may come with a price to build stability on the 2.7.x LTS branch. If the price is too high, we could still remove those extensions later on.

@aldettinger aldettinger merged commit a665ddc into apache:main Mar 18, 2022
@aldettinger aldettinger deleted the CAMEL-QUARKUS-3532 branch March 18, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesnetherton jamesnetherton jamesnetherton left review comments

@zhfeng zhfeng zhfeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aldettinger @jamesnetherton @zhfeng