Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban javax.validation and junit 4 #3673

Merged
merged 3 commits into from Mar 29, 2022
Merged

Ban javax.validation and junit 4 #3673

merged 3 commits into from Mar 29, 2022

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Mar 28, 2022

Fix #3504
Fix #3354

@ppalaga ppalaga force-pushed the 220328-ban-javax.validation branch from 87a3994 to e801c2a Compare March 29, 2022 06:56
aldettinger
aldettinger approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@aldettinger aldettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @ppalaga. Especially those remaining JUnit 4 assertions.

@ppalaga ppalaga merged commit 5c2b738 into apache:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhfeng zhfeng zhfeng approved these changes

@oscerd oscerd oscerd approved these changes

@aldettinger aldettinger aldettinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ban javax.validation in favor of jakarta.validation Ban junit 4
4 participants
@ppalaga @zhfeng @oscerd @aldettinger