Fix #3656 Improve camel-quarkus-paho-mqtt5 test coverage #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhfeng
force-pushed
the
issue_3656_improve_test_coverage_paho_mqtt5
branch
from
fe04663
to
7d25a4d
Compare
|
|
||
| private void removeKeyStore(String keystore) { | ||
| try { | ||
| Files.delete(Paths.get(keystore)); |
There was a problem hiding this comment.
Should we unset the SSL system properties here?
There was a problem hiding this comment.
good catch! I will unset these properties.
There was a problem hiding this comment.
Also, I guess we want this to always happen. E.g even if the call to the ProducerTemplate throws an exception.
aldettinger
reviewed
Apr 8, 2022
...t5/src/test/java/org/apache/camel/quarkus/component/paho/mqtt5/it/PahoMqtt5TestResource.java
Show resolved
Hide resolved
aldettinger
approved these changes
Apr 8, 2022
zhfeng
force-pushed
the
issue_3656_improve_test_coverage_paho_mqtt5
branch
from
385912c
to
b100281
Compare
jamesnetherton
approved these changes
Apr 11, 2022
ppalaga
pushed a commit
to ppalaga/camel-quarkus
that referenced
this pull request
Apr 12, 2022
ppalaga
pushed a commit
that referenced
this pull request
Apr 18, 2022
ppalaga
pushed a commit
to ppalaga/camel-quarkus
that referenced
this pull request
Apr 22, 2022
jamesnetherton
pushed a commit
to jboss-fuse/camel-quarkus
that referenced
this pull request
Apr 25, 2022
ppalaga
pushed a commit
to jboss-fuse/camel-quarkus
that referenced
this pull request
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.