paho: expand test coverage #3720 #3721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldettinger
force-pushed
the
CAMEL-QUARKUS-3720
branch
from
691ae7b
to
6343bfc
Compare
ppalaga
reviewed
Apr 12, 2022
Comment on lines
+130
to
+132
| InputStream in = Thread.currentThread().getContextClassLoader().getResourceAsStream(keystore); | ||
|
|
||
| try { |
There was a problem hiding this comment.
Suggested change
| InputStream in = Thread.currentThread().getContextClassLoader().getResourceAsStream(keystore); | |
| try { | |
| try (InputStream in = Thread.currentThread().getContextClassLoader().getResourceAsStream(keystore)) { |
It would be nice if we could close the InputStream
integration-tests/paho/src/main/java/org/apache/camel/quarkus/component/paho/PahoResource.java
Show resolved
Hide resolved
| InputStream in = Thread.currentThread().getContextClassLoader().getResourceAsStream(keystore); | ||
|
|
||
| try { | ||
| Files.copy(in, Paths.get(keystore), StandardCopyOption.REPLACE_EXISTING); |
There was a problem hiding this comment.
Woudn't this copy the file to the given module's root directory, where somebody could inadvertently add it to git? Maybe under tmp or target could be better?
There was a problem hiding this comment.
yeah, I agree and prefer to create a tmp file. Thanks @ppalaga !
|
@aldettinger it could be useful to create a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.