Fix #3728 AWS S3 integration test should remove all objects in finall… #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Apr 14, 2022
essobedo
reviewed
Apr 14, 2022
| .body(is(blobContent)); | ||
| } finally { | ||
| // Delete | ||
| deleteObject(oid); |
There was a problem hiding this comment.
Should be done in an AfterEach method instead of a finally block
There was a problem hiding this comment.
The oid is a random generated id and there are some other tests such as copyObjectDeleteBucket which has a different test logic. There's also a @AfterEach method to check the objects leaking.
There was a problem hiding this comment.
@essobedo thanks for the review!
We were hit by high AWS bills in the past when tests were either missing cleanup code or when something failed midair and the cleanup code was not invoked. Using try-catch helps to address both: missing cleanup code is easier to spot and existing cleanup code is harder to skip. Thus +1 for this change from my side.
ppalaga
approved these changes
Apr 14, 2022
ppalaga
pushed a commit
to ppalaga/camel-quarkus
that referenced
this pull request
Apr 18, 2022
ppalaga
pushed a commit
that referenced
this pull request
Apr 18, 2022
ppalaga
pushed a commit
to ppalaga/camel-quarkus
that referenced
this pull request
Apr 22, 2022
jamesnetherton
pushed a commit
to jboss-fuse/camel-quarkus
that referenced
this pull request
Apr 25, 2022
ppalaga
pushed a commit
to jboss-fuse/camel-quarkus
that referenced
this pull request
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y block