Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camel DataSonnet Extension - resolves Issue #2078 (needs Scala >= 2.13) #3757

Closed
wants to merge 7 commits into from
Closed

Conversation

javaduke
Copy link
Contributor

No description provided.

@javaduke
Copy link
Contributor Author

@aldettinger I created this PR and I'm going to close the old one.

@javaduke
Copy link
Contributor Author

Hmm, not sure what this error means:

Caused by: java.lang.RuntimeException: Too little or too much org.apache.camel:* entries in camel-quarkus-bom:
[2920](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2920)

[2921](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2921)
    Extra content at line 89:
[2922](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2922)
  ["org.apache.camel:camel-datasonnet"]
[2923](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2923)

[2924](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2924)

[2925](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2925)
Consider adding, removing or excluding them in the BOM

Are there any dependencies I need to exclude?

@ppalaga
Copy link
Contributor

ppalaga commented May 2, 2022

Hmm, not sure what this error means:

Caused by: java.lang.RuntimeException: Too little or too much org.apache.camel:* entries in camel-quarkus-bom:
[2920](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2920)

[2921](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2921)
    Extra content at line 89:
[2922](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2922)
  ["org.apache.camel:camel-datasonnet"]
[2923](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2923)

[2924](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2924)

[2925](https://github.com/apache/camel-quarkus/runs/6214331067?check_suite_focus=true#step:8:2925)
Consider adding, removing or excluding them in the BOM

Are there any dependencies I need to exclude?

Looks like you figured out in between?

Once again please, if you could rebase on top of target branch rather than merging it. The resulting history is much easier to read like that. Also, if you could please squash your commits for the same reason.

@javaduke
Copy link
Contributor Author

javaduke commented May 2, 2022

Really sorry about it, I tried to squash and rebase, but ran into al kinds of conflicts and errors and ended up making a mess again. Would it be possible to squash and merge the PR instead?

@ppalaga
Copy link
Contributor

ppalaga commented May 4, 2022

Really sorry about it, I tried to squash and rebase, but ran into al kinds of conflicts and errors and ended up making a mess again.
Would it be possible to squash and merge the PR instead?

I doubt it is even possible as long as there are conflicts. Basically it is you who should know best how to solve them. BTW, having less commits in the topic branch may make rebasing a bit easier.
I guess after #3767 is merged, this PR can again target the main branch.

@javaduke
Copy link
Contributor Author

javaduke commented May 4, 2022

OK, I'll close this one and will open a new one to main

@javaduke javaduke closed this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants