Improve camel-quarkus-velocity test coverage #3790 #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
May 17, 2022
integration-tests/velocity/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
aldettinger
approved these changes
May 18, 2022
There was a problem hiding this comment.
I agree with previous comments. Once clarified, I think it will be ok to merge this PR.
Further, I wonder if more tests would be needed ? More details in the ticket.
JiriOndrusek
force-pushed
the
velocity-tests
branch
from
5940283
to
5127a3c
Compare
JiriOndrusek
force-pushed
the
velocity-tests
branch
from
5127a3c
to
2adfd5f
Compare
JiriOndrusek
commented
May 19, 2022
| Map<String, Object> variableMap = new HashMap<>(); | ||
| variableMap.put("headers", CollectionHelper.mapOf("name", name)); | ||
| variableMap.put("body", "Monday"); | ||
| variableMap.put("properties", exchange.getProperties()); |
There was a problem hiding this comment.
(Just pointing to the place, where exchange was originally put into context, I switched it for the properties map, therefore now there is no problem)
zhfeng
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3790